Skip to content

London | 26 ITP May | Sayeed Hussain | Sprint 2 | Wireframe#1315

Open
sayeedhussain01 wants to merge 7 commits into
CodeYourFuture:mainfrom
sayeedhussain01:feature/wireframe
Open

London | 26 ITP May | Sayeed Hussain | Sprint 2 | Wireframe#1315
sayeedhussain01 wants to merge 7 commits into
CodeYourFuture:mainfrom
sayeedhussain01:feature/wireframe

Conversation

@sayeedhussain01
Copy link
Copy Markdown

@sayeedhussain01 sayeedhussain01 commented May 19, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have added images ,title, summary and detailed link for each content .

@netlify
Copy link
Copy Markdown

netlify Bot commented May 19, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit b2712c2
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a0c5f7976def0000881fb6f
😎 Deploy Preview https://deploy-preview-1315--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@sayeedhussain01 sayeedhussain01 added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels May 19, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@sayeedhussain01 sayeedhussain01 changed the title London | ITP May 26 | Sayeed Hussain | Sprint 2 | Feature/wireframe London | ITP May 26 | Sayeed Hussain | Sprint 2 | Wireframe May 19, 2026
@github-actions

This comment has been minimized.

@sayeedhussain01 sayeedhussain01 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@sayeedhussain01 sayeedhussain01 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@sayeedhussain01 sayeedhussain01 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@sayeedhussain01 sayeedhussain01 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@sayeedhussain01 sayeedhussain01 removed the 📅 Sprint 2 Assigned during Sprint 2 of this module label May 19, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@sayeedhussain01 sayeedhussain01 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@sayeedhussain01 sayeedhussain01 changed the title London | ITP May 26 | Sayeed Hussain | Sprint 2 | Wireframe London | 26 ITP May | Sayeed Hussain | Sprint 2 | Wireframe May 19, 2026
@github-actions

This comment has been minimized.

@sayeedhussain01 sayeedhussain01 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@sayeedhussain01 sayeedhussain01 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code looks good.

  • The page layout is quite solid, but the title, sub-title, and footer are not yet fully centered on the page. Can you address this issue?

  • I noticed the following issues in the text content:

    • Some words are misspelled or use incorrect letter casing.
    • Spacing around punctuation marks is inconsistent.

    Could you run it through an AI tool to identify any potential improvements, even minor ones, to help ensure the content is fully polished?

Comment thread Wireframe/index.html
</article>

<article>
<img src="/Wireframe/1_mtsk3fQ_BRemFidhkel3dA.webp" alt="">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing meaningful alt text is important because it ensures images are accessible to people using screen readers and also helps when images
fail to load, giving users essential context about the content or function of the image.

Can you give a more descriptive alt value to all images?

Comment thread Wireframe/style.css
Comment on lines +76 to 80
margin-right: 20px;
border-top: 2px solid;
width: 1515px;
margin-top: 200px;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off.

As a best practice, consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.

Please note that code formatters may not work correctly when the source code contains syntax errors.

If formatting is not working in VS Code, check your code for syntax errors and resolve them before running the formatter again.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants